[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v3 03/12] Include qemu/module.h where needed, dro
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PULL v3 03/12] Include qemu/module.h where needed, drop it from qemu-common.h |
|
Date: |
Mon, 24 Jun 2019 19:14:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hi Markus,
On 6/12/19 1:27 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> Message-Id: <address@hidden>
> [Rebased with conflicts resolved automatically, except for
> hw/usb/dev-hub.c hw/misc/exynos4210_rng.c hw/misc/bcm2835_rng.c
> hw/misc/aspeed_scu.c hw/display/virtio-vga.c hw/arm/stm32f205_soc.c;
> ui/cocoa.m fixed up]
> ---
[...]
> hw/core/empty_slot.c | 1 +
[...]
> diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c
> index 239f78e2a7..c694532046 100644
> --- a/hw/core/empty_slot.c
> +++ b/hw/core/empty_slot.c
> @@ -12,6 +12,7 @@
> #include "qemu/osdep.h"
> #include "hw/hw.h"
> #include "hw/sysbus.h"
> +#include "qemu/module.h"
> #include "hw/empty_slot.h"
>
> //#define DEBUG_EMPTY_SLOT
Why is this include required in this file?
I think I'm missing how modules are used.
Thanks,
Phil.