Re: [Qemu-devel] [RFC PATCH 2/9] MAINTAINERS: Add the 'empty_slot' device with the 'unimp' one

[Artyom Tarasenko]

On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> The EmptySlot and UnimplementedDevice are very similar, the only
> difference is how they log guest accesses.
> Maintain them altogether.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Artyom Tarasenko <address@hidden>

> ---
> Peter, are you OK with that? Do you prefer 2 distinct sections?
>
>  MAINTAINERS | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cad58b9487..abef4a1cfc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1643,11 +1643,13 @@ F: docs/specs/vmgenid.txt
>  F: tests/vmgenid-test.c
>  F: stubs/vmgenid.c
>
> -Unimplemented device
> +Unimplemented device, empty slot device
>  M: Peter Maydell <address@hidden>
>  R: Philippe Mathieu-Daudé <address@hidden>
>  S: Maintained
> +F: include/hw/misc/empty_slot.h
>  F: include/hw/misc/unimp.h
> +F: hw/misc/empty_slot.c
>  F: hw/misc/unimp.c
>
>  Standard VGA
> --
> 2.19.1
>


-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu