[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] hw/sparc/sun4m: Mark some devices as 'unimp
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] hw/sparc/sun4m: Mark some devices as 'unimplemented' |
Date: |
Tue, 25 Jun 2019 09:16:30 +0200 |
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> These devices are not slots on a bus, but real devices that
> we do not implement.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Artyom Tarasenko <address@hidden>
> ---
> hw/sparc/sun4m.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
> index cc85598d5b..0df5a8edfc 100644
> --- a/hw/sparc/sun4m.c
> +++ b/hw/sparc/sun4m.c
> @@ -42,6 +42,7 @@
> #include "hw/nvram/fw_cfg.h"
> #include "hw/char/escc.h"
> #include "hw/misc/empty_slot.h"
> +#include "hw/misc/unimp.h"
> #include "hw/loader.h"
> #include "elf.h"
> #include "trace.h"
> @@ -970,7 +971,7 @@ static void sun4m_hw_init(const struct sun4m_hwdef *hwdef,
> }
>
> if (hwdef->sx_base) {
> - empty_slot_init(hwdef->sx_base, 0x2000);
> + create_unimplemented_device("sx", hwdef->sx_base, 0x2000);
> }
>
> nvram = m48t59_init(slavio_irq[0], hwdef->nvram_base, 0, 0x2000, 1968,
> 8);
> @@ -1033,14 +1034,16 @@ static void sun4m_hw_init(const struct sun4m_hwdef
> *hwdef,
> if (hwdef->dbri_base) {
> /* ISDN chip with attached CS4215 audio codec */
> /* prom space */
> - empty_slot_init(hwdef->dbri_base+0x1000, 0x30);
> + create_unimplemented_device("SUNW,DBRI.prom",
> + hwdef->dbri_base + 0x1000, 0x30);
> /* reg space */
> - empty_slot_init(hwdef->dbri_base+0x10000, 0x100);
> + create_unimplemented_device("SUNW,DBRI",
> + hwdef->dbri_base + 0x10000, 0x100);
> }
>
> if (hwdef->bpp_base) {
> /* parallel port */
> - empty_slot_init(hwdef->bpp_base, 0x20);
> + create_unimplemented_device("parallel", hwdef->bpp_base, 0x20);
> }
>
> initrd_size = 0;
> --
> 2.19.1
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
- [Qemu-devel] [PATCH 0/9] hw/misc: Clean the empty_slot device, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 1/9] hw/misc: Move the 'empty_slot' device to hw/misc/, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [RFC PATCH 2/9] MAINTAINERS: Add the 'empty_slot' device with the 'unimp' one, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 7/9] hw/sparc/sun4m: Mark some devices as 'unimplemented', Philippe Mathieu-Daudé, 2019/06/24
- Re: [Qemu-devel] [PATCH 7/9] hw/sparc/sun4m: Mark some devices as 'unimplemented',
Artyom Tarasenko <=
- [Qemu-devel] [PATCH 5/9] hw/misc/empty_slot: Add a qdev property 'name', Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 3/9] hw/misc/empty_slot: Allow overide by device with higher priority, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 6/9] hw/misc/empty_slot: Convert debug printf()s to trace events, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 9/9] hw/misc/empty_slot: Pass the slot name as argument, Philippe Mathieu-Daudé, 2019/06/24
- [Qemu-devel] [PATCH 8/9] hw/sparc/sun4m: Simplify the RAM creation, Philippe Mathieu-Daudé, 2019/06/24