Re: [Qemu-devel] [PATCH v5 2/2] ati-vga: Implement DDC and EDID info from monitor

[BALATON Zoltan]

On Tue, 25 Jun 2019, Corey Minyard wrote:
> On Thu, Jun 20, 2019 at 12:55:23PM +0200, BALATON Zoltan wrote:
> > This adds DDC support to ati-vga and connects i2c-ddc to it. This
> > allows at least MacOS with an ATI ndrv, Linux radeonfb and MorphOS to
> > get monitor EDID info (although MorphOS splash screen is not displayed
> > and radeonfb needs additional tables from vgabios-rv100). Xorg needs
> > additional support from VESA vgabios, it's missing INT10 0x4F15
> > function (see
> > https://gitlab.freedesktop.org/xorg/xserver/blob/master/hw/xfree86/vbe/vbe.c)
> > without which no DDC is available that also prevents loading the
> > accelerated X driver.
> >
> > Signed-off-by: BALATON Zoltan <address@hidden>
>
> This patch also looks good, and thanks to Gerd for reviewing.
>
> I didn't see the followup documentation patch that Gerd suggested, did
> I miss that?
>
> Also, how would you like to handle these?

Gerd has already queued them (including the requested follow up to update 
comment which I think only cc'd to Gerd that's why you may have missed it, 
but another fix up I've sent adding reg names to ati_dbg.h may still be 
missing from Gerd's tree). I think Gerd can send these via his tree with 
your Acked-by on the i2c patch which should be OK if nobody disagrees.

There's still the issue with cleaning up bitbang_i2c that results in an 
ASan warning which we have discussed before:
https://lists.nongnu.org/archive/html/qemu-devel/2019-03/msg05966.html
but we could not find an easy fix so since it's preexisting problem it can 
be fixed later. Although, I don't have plans to fix that, only mentioning 
it here as a reminder.

Thank you,
BALATON Zoltan