Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] nbd: enable keepalive

[Eric Blake]

On 6/26/19 4:18 PM, John Snow wrote:
> 
> 
> On 6/5/19 12:18 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is a suggestion to enable keepalive option to track server availablity.
>> We suggest to enable it by default. If we need, we'll be able to add option
>> to specify timeout by hand later.
>>
>> v2: 01 - Fix io channel returned errors to be -1 [Daniel]
>>     02 - Fix typo in commit message [Eric]
>>
>> Vladimir Sementsov-Ogievskiy (2):
>>   io/channel: add qio_channel_set_keepalive
>>   nbd-client: enable TCP keepalive
>>
>>  include/io/channel.h | 15 +++++++++++++++
>>  block/nbd-client.c   |  1 +
>>  io/channel-socket.c  | 20 ++++++++++++++++++++
>>  io/channel.c         | 14 ++++++++++++++
>>  4 files changed, 50 insertions(+)
>>
> 
> Ping -- I think this was good to go with Dan's ACK, based on the
> discussion from v1.

Actually, I thought that we changed tactics, and that the latest version is:

https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01989.html

[PATCH v2] qapi: InitSocketAddress: add keepalive option

to make the setting conditional based on blockdev parameters rather than
unconditional.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature