Re: [Qemu-devel] [PATCH v13 0/5] linux-user: A set of miscellaneous patches

[Laurent Vivier]

Le 27/06/2019 à 21:27, address@hidden a écrit :
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> # Testing script will be invoked under the git checkout with
> # HEAD pointing to a commit that has the patches applied on top of "base"
> # branch
> set -e
> CC=$HOME/bin/cc
> INSTALL=$PWD/install
> BUILD=$PWD/build
> mkdir -p $BUILD $INSTALL
> SRC=$PWD
> cd $BUILD
> $SRC/configure --cc=$CC --prefix=$INSTALL
> make -j4
> # XXX: we need reliable clean up
> # make check -j4 V=1
> make install
> 
> echo
> echo "=== ENV ==="
> env
> 
> echo
> echo "=== PACKAGES ==="
> rpm -qa
> === TEST SCRIPT END ===
> 
>   CC      i386-linux-user/linux-user/uname.o
>   CCAS    i386-linux-user/linux-user/safe-syscall.o
>   CC      i386-linux-user/linux-user/i386/signal.o
> /var/tmp/patchew-tester-tmp-zqhqa95y/src/linux-user/syscall.c:323:16: error: 
> conflicting types for ‘statx’
>   323 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags,
>       |                ^~~~~
> /var/tmp/patchew-tester-tmp-zqhqa95y/src/linux-user/syscall.c:214:13: note: 
> in definition of macro ‘_syscall5’
> 

This is a real error. To avoid this you can rename it to "sys_statx"
(see sys_gettid() for instance).

Thanks,
Laurent