Re: [Qemu-devel] [PATCH v16 1/5] linux-user: Add support for translation of statx() syscall

[Jim Wilson]

On Fri, Jun 28, 2019 at 5:53 PM Aleksandar Markovic
<address@hidden> wrote:
> This patch went trough several transformations in last few days, and I am a 
> little worried that we forgot the primary reasons/scenarios why want it in 
> the first place. In that light, may I ask you to recheck this latest version 
> of the patch, v16, against your scenarios (you mentioned earlier you have two 
> significantly different flavors of your scenario, one with Ubuntu 16, and 
> another with Ubuntu 19)?

My use case is that I want 32-bit RISC-V user mode to work.  This
requires a riscv syscall list patch that Palmer Dabbelt added to his
patch set, and the statx patch that is part of your patch set.  The
statx strace support is not required for this use case, but should be
added for completeness as all of the other stat family functions have
strace support, so statx should too.  Since the statx strace patch
needs statx macros that old systems don't have, I test on Ubuntu 16
(no host statx) and Ubuntu 19 (with host statx).  On Ubuntu 19, statx
strace should be fully pretty printed.  On Ubuntu 16, qemu should
still build despite the missing macros, and statx strace should be
partially pretty printed because of the missing macros.

I removed the old patches, updated qemu, added the new patches,
rebuilt qemu, and reran the gcc testsuite for rv32/rv64 Ubuntu 16/19
and it still works as expected.  I also manually checked strace for
rv32/rv64 Ubuntu 16/19 and that also still works as expected.  So this
looks good to me.

I'm leaving on a trip tomorrow, and only taking one laptop with me, so
I won't have access to my Ubuntu 19 machine anymore.

Jim