Re: [Qemu-devel] [PATCH v4 06/54] trace: expand mem_info:size_shift to 4 bits

[Richard Henderson]

On 7/31/19 9:06 AM, Alex Bennée wrote:
> From: "Emilio G. Cota" <address@hidden>
> 
> This will allow us to trace 32k-long memory accesses (although our
> maximum is something like 256 bytes at the moment).
> 
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> [AJB: expanded to 3->4 bits]
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  trace-events | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trace-events b/trace-events
> index aeea3c2bdbf..63bb192ade6 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -149,7 +149,7 @@ vcpu guest_cpu_reset(void)
>  # Access information can be parsed as:
>  #
>  # struct mem_info {
> -#     uint8_t size_shift : 2; /* interpreted as "1 << size_shift" bytes */
> +#     uint8_t size_shift : 4; /* interpreted as "1 << size_shift" bytes */
>  #     bool    sign_extend: 1; /* sign-extended */
>  #     uint8_t endianness : 1; /* 0: little, 1: big */
>  #     bool    store      : 1; /* wheter it's a store operation */
> 

Adjusting the comment doesn't do anything, and neither the before or the after
match the actual code:

#define TRACE_MEM_SZ_SHIFT_MASK 0x7 /* size shift mask */

Is this a victim of a rebase, with the changes to trace/mem-internal.h moved to
a different patch?


r~