|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v3 02/22] libqos: Rename i2c_send and i2c_recv |
| Date: | Thu, 19 Sep 2019 13:15:25 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 19/09/19 01:19, Oleinik, Alexander wrote:
> The names i2c_send and i2c_recv collide with functions defined in
> hw/i2c/core.c. This causes an error when linking against libqos and
> softmmu simultaneously (for example when using qtest inproc). Rename the
> libqos functions to avoid this.
I'd prefer "qi2c_{send,recv}" since that is consistent with "qvirtio_"
functions and with the name of the "QI2CDevice" struct.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |