|
| From: | Markus Armbruster |
| Subject: | Re: [PATCH v4 03/31] net/net: fix local variable shadowing in net_client_init |
| Date: | Tue, 08 Oct 2019 16:34:02 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <address@hidden> writes:
> Don't shadow Error *err: it's a bad thing.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Looks like a cleanup, not a bug fix. If that's the case, the commit
message should say so:
net/net: Clean up variable shadowing in net_client_init()
Variable int err in inner scope shadows Error *err in outer scope.
Patch looks good to me.
| [Prev in Thread] | Current Thread | [Next in Thread] |