[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings
|
From: |
Chubb, Peter (Data61, Kensington NSW) |
|
Subject: |
Re: [PATCH 0/6] Fix more GCC9 -O3 warnings |
|
Date: |
Tue, 17 Dec 2019 21:49:35 +0000 |
>>>>> "Philippe" == Philippe Mathieu-Daudé <address@hidden> writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement is a different matter, and should be
done. Seems to me that until gcc started warning for this, noone had
actually run a checker, and the comments were just for human info.
Peter C
--
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group Data61 (formerly NICTA)