Re: [PULL 32/41] target/mips: Use cpu_*_mmuidx_ra instead of MMU_MODE*_SUFFIX

[Thomas Huth]

On 01/02/2020 21.12, Philippe Mathieu-Daudé wrote:
> Hi Richard,
> 
> On 1/8/20 4:45 AM, Richard Henderson wrote:
>> The separate suffixed functions were used to construct
>> some do_##insn function switched on mmu_idx.  The interface
>> is exactly identical to the *_mmuidx_ra functions.  Replace
>> them directly and remove the constructions.
>>
>> Cc: Aurelien Jarno <address@hidden>
>> Cc: Aleksandar Rikalo <address@hidden>
>> Tested-by: Philippe Mathieu-Daudé <address@hidden>
> 
> I'm seeing a regression since commit 7dd547e5a (however I'm not sure
> this particular commit introduced the regression, or instead revealed it).
> 
> I get a hang when booting a I6400 CPU on Malta:
> 
> $ qemu-system-mips64el -cpu I6400 -serial stdio \
>   -kernel vmlinux \
>   -append "clocksource=GIC console=ttyS0 printk.time=1"
[...]

Thanks for the bisection, Philippe, that saved me quite a bit of time
doing it myself: The same problem also exists with the big-endian
version - this is also the commit that broke the Day 22 image of the
QEMU advent calendar 2018:

 https://www.qemu-advent-calendar.org/2018/download/day22.tar.xz

  Thomas