[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pl031: add finalize function to avoid memleaks
|
From: |
Pan Nengyuan |
|
Subject: |
Re: [PATCH] pl031: add finalize function to avoid memleaks |
|
Date: |
Mon, 3 Feb 2020 16:13:24 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 2/3/2020 3:59 PM, Richard Henderson wrote:
> On 2/3/20 7:47 AM, address@hidden wrote:
>> +static void pl031_finalize(Object *obj)
>> +{
>> + PL031State *s = PL031(obj);
>> + if (s->timer) {
>
> As far as I can see, s->timer can never be null.
Yes, it's no instances, just seems safer.
Thanks.
>
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~
>