Re: [PATCH qemu] spapr/rtas: Print message from "ibm,os-term"

[Daniel Henrique Barboza]

On 2/3/20 12:20 AM, Alexey Kardashevskiy wrote:
> The "ibm,os-term" RTAS call has a single parameter which is a pointer to
> a message from the guest kernel about the termination cause; this prints
> it.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>   hw/ppc/spapr_rtas.c | 7 +++++++
>   1 file changed, 7 insertions(+)

Reviewed-by: Daniel Henrique Barboza <address@hidden>


> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 883fe28465e6..656fdd221665 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -345,6 +345,13 @@ static void rtas_ibm_os_term(PowerPCCPU *cpu,
>                               target_ulong args,
>                               uint32_t nret, target_ulong rets)
>   {
> +    target_ulong msgaddr = rtas_ld(args, 0);
> +    char msg[512];
> +
> +    cpu_physical_memory_read(msgaddr, msg, sizeof(msg) - 1);
> +    msg[sizeof(msg) - 1] = 0;
> +
> +    error_report("OS terminated: %s", msg);
>       qemu_system_guest_panicked(NULL);
>   
>       rtas_st(rets, 0, RTAS_OUT_SUCCESS);