Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own file

[Philippe Mathieu-Daudé]

On 2/4/20 7:42 AM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> For clarity and easier maintenence, create target/mips/fpu_helper.c, and
> move all FPU-related content form target/mips/op_helper.c to that file.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Reviewed-by: Aleksandar Rikalo <address@hidden>
> Message-Id: <address@hidden>
> ---
>   target/mips/Makefile.objs |    2 +-
>   target/mips/fpu_helper.c  | 1911 +++++++++++++++++++++++++++++++++++++++++++++
>   target/mips/op_helper.c   | 1877 --------------------------------------------
>   3 files changed, 1912 insertions(+), 1878 deletions(-)
>   create mode 100644 target/mips/fpu_helper.c
>
> diff --git a/target/mips/Makefile.objs b/target/mips/Makefile.objs
> index 3ca2bde..91eb691 100644
> --- a/target/mips/Makefile.objs
> +++ b/target/mips/Makefile.objs
> @@ -1,5 +1,5 @@
>   obj-y += translate.o cpu.o gdbstub.o helper.o
> -obj-y += op_helper.o cp0_helper.o
> +obj-y += op_helper.o cp0_helper.o fpu_helper.o
>   obj-y += dsp_helper.o lmi_helper.o msa_helper.o
>   obj-$(CONFIG_SOFTMMU) += mips-semi.o
>   obj-$(CONFIG_SOFTMMU) += machine.o cp0_timer.o
> diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c
> new file mode 100644
> index 0000000..0d5769e
> --- /dev/null
> +++ b/target/mips/fpu_helper.c
> @@ -0,0 +1,1911 @@
> +/*
> + *  Helpers for emulation of CP0-related MIPS instructions.

Isn't it "FPU"?

> + *
> + *  Copyright (C) 2004-2005  Jocelyn Mayer
> + *  Copyright (C) 2020  Wave Computing, Inc.
> + *  Copyright (C) 2020  Aleksandar Markovic <address@hidden>
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> + *
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qemu/main-loop.h"
> +#include "cpu.h"
> +#include "internal.h"
> +#include "qemu/host-utils.h"
> +#include "exec/helper-proto.h"
> +#include "exec/exec-all.h"
> +#include "exec/cpu_ldst.h"
> +#include "exec/memop.h"
> +#include "sysemu/kvm.h"
> +#include "fpu/softfloat.h"