[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context mana
From: |
Wainer dos Santos Moschetta |
Subject: |
[PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager |
Date: |
Tue, 4 Feb 2020 11:11:10 -0300 |
This implement the __enter__ and __exit__ functions on
QEMUMonitorProtocol class so that it can be used on 'with'
statement and the resources will be free up on block end:
with QEMUMonitorProtocol(socket_path) as qmp:
qmp.connect()
qmp.command('query-status')
Signed-off-by: Wainer dos Santos Moschetta <address@hidden>
---
python/qemu/qmp.py | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py
index 0e07d80e2a..486a566da0 100644
--- a/python/qemu/qmp.py
+++ b/python/qemu/qmp.py
@@ -139,6 +139,15 @@ class QEMUMonitorProtocol:
raise QMPConnectError("Error while reading from socket")
self.__sock.settimeout(None)
+ def __enter__(self):
+ # Implement context manager enter function.
+ return self
+
+ def __exit__(self, exc_type, exc_value, exc_traceback):
+ # Implement context manager exit function.
+ self.close()
+ return False
+
def connect(self, negotiate=True):
"""
Connect to the QMP Monitor and perform capabilities negotiation.
@@ -265,8 +274,10 @@ class QEMUMonitorProtocol:
"""
Close the socket and socket file.
"""
- self.__sock.close()
- self.__sockfile.close()
+ if self.__sock:
+ self.__sock.close()
+ if self.__sockfile:
+ self.__sockfile.close()
def settimeout(self, timeout):
"""
--
2.23.0
- [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements, Wainer dos Santos Moschetta, 2020/02/04
- [PATCH v2 1/5] python/qemu: qmp: Replace socket.error with OSError, Wainer dos Santos Moschetta, 2020/02/04
- [PATCH v2 2/5] python/qemu: Delint the qmp module, Wainer dos Santos Moschetta, 2020/02/04
- [PATCH v2 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager,
Wainer dos Santos Moschetta <=
- [PATCH v2 5/5] python/qemu: qmp: Remove unnused attributes, Wainer dos Santos Moschetta, 2020/02/04
- [PATCH v2 3/5] python/qemu: qmp: Make accept()'s timeout configurable, Wainer dos Santos Moschetta, 2020/02/04
- Re: [PATCH v2 0/5] python/qemu: qmp: Fix, delint and improvements, Philippe Mathieu-Daudé, 2020/02/06