qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG


From: Eric Blake
Subject: Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
Date: Tue, 4 Feb 2020 11:29:27 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/4/20 10:56 AM, John Snow wrote:
This is the only instance of a non-zero constant not using a symbolic
constant.
---
  qemu-options.hx | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Eric Blake <address@hidden>

diff --git a/qemu-options.hx b/qemu-options.hx
index 224a8e8712..ff3e806977 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1955,7 +1955,7 @@ STEXI
  Start in full screen.
  ETEXI
-DEF("g", 1, QEMU_OPTION_g ,
+DEF("g", HAS_ARG, QEMU_OPTION_g ,
      "-g WxH[xDEPTH]  Set the initial graphical resolution and depth\n",
      QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
  STEXI


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]