[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] exec: do not define use_icount for user-mode emulation
From: |
Alex Bennée |
Subject: |
Re: [PATCH] exec: do not define use_icount for user-mode emulation |
Date: |
Tue, 04 Feb 2020 17:38:32 +0000 |
User-agent: |
mu4e 1.3.7; emacs 27.0.60 |
Paolo Bonzini <address@hidden> writes:
> use_icount is also defined by stubs/cpu-get-icount.c, we do not need
> to have a useless definition in exec.c.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> exec.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 67e520d18e..5fc3746053 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -98,15 +98,15 @@ CPUTailQ cpus = QTAILQ_HEAD_INITIALIZER(cpus);
> /* current CPU in the current thread. It is only valid inside
> cpu_exec() */
> __thread CPUState *current_cpu;
> -/* 0 = Do not count executed instructions.
> - 1 = Precise instruction counting.
> - 2 = Adaptive rate instruction counting. */
> -int use_icount;
>
> uintptr_t qemu_host_page_size;
> intptr_t qemu_host_page_mask;
>
> #if !defined(CONFIG_USER_ONLY)
> +/* 0 = Do not count executed instructions.
> + 1 = Precise instruction counting.
> + 2 = Adaptive rate instruction counting. */
> +int use_icount;
>
> typedef struct PhysPageEntry PhysPageEntry;
--
Alex Bennée