Re: [PATCH qemu v6 6/6] spapr: Implement Open Firmware client interface

[Alexey Kardashevskiy]

On 04/02/2020 00:03, BALATON Zoltan wrote:
> On Mon, 3 Feb 2020, Alexey Kardashevskiy wrote:
> [...]
>> diff --git a/hw/ppc/spapr_of_client.c b/hw/ppc/spapr_of_client.c
>> new file mode 100644
>> index 000000000000..31555c356de8
>> --- /dev/null
>> +++ b/hw/ppc/spapr_of_client.c
>> @@ -0,0 +1,1526 @@
>> +#include "qemu/osdep.h"
>> +#include "qemu-common.h"
>> +#include <sys/ioctl.h>
>> +#include <termios.h>
>> +#include "qapi/error.h"
>> +#include "exec/memory.h"
>> +#include "hw/ppc/spapr.h"
>> +#include "hw/ppc/spapr_vio.h"
> 
> I haven't read all of this as it's a lot of code but I was thinking this
> might also be useful to implement a replacement for the proprietary
> firmware of the pegasos2 emulation later. See:
> 
> https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2
> 
> for details. I likely don't need a complete OpenFirmware for booting
> Linux and MorphOS as these only get some data from the device tree and
> then use their own drivers (MorphOS may use some RTAS but I'm not sure)
> so something like this might be enough to get these booting without the
> original firmware on pegasos2 and is easier than reimplementing the
> firmware or trying to modify OpenFirmware to emulate the different
> device tree that machine has.
> 
> Question is if it's possible to make this file independent of spapr or
> gather the OF emulation parts in a separate file that could be reused
> later? This could be done afterwards but if there's anything now that
> you can do to make it easier then that would help so maybe it's good
> idea to make you aware of this in case you can consider this possible
> use case.


I can separate OF CI part from the SpaprMachineState but so far I was
not successful in convincing the community about usefulness of this.



-- 
Alexey