[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] memory: Use QEMU_ALWAYS_INLINE to silence compile-time warni
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] memory: Use QEMU_ALWAYS_INLINE to silence compile-time warning |
|
Date: |
Wed, 5 Feb 2020 10:01:11 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/5/20 8:17 AM, Zenghui Yu wrote:
> Our robot reported the following compile-time warning while compiling
> Qemu with -fno-inline cflags:
Why are you doing this?
>
> In function 'load_memop',
> inlined from 'load_helper' at /qemu/accel/tcg/cputlb.c:1578:20,
> inlined from 'full_ldub_mmu' at /qemu/accel/tcg/cputlb.c:1624:12:
> /qemu/accel/tcg/cputlb.c:1502:9: error: call to 'qemu_build_not_reached'
> declared with attribute error: code path is reachable
> qemu_build_not_reached();
> ^~~~~~~~~~~~~~~~~~~~~~~~
> [...]
Of course, the assert is compiled out when optimization is off, which is the
only time we expect inlining to be off.
The patch isn't wrong, exactly, but I question whether we want to support
completely arbitrary combinations of compile flags.
r~