Re: [PATCH v2 24/29] tests/acceptance/virtio_check_params: Default to -nodefaults

[Thomas Huth]

On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote:
> We don't need the default options to run this test.
> 
> This fixes errors when running a binary built with
> --without-default-devices such:
> 
>   ERROR: qemu-system-s390x: Unknown device 'virtio-net-ccw' for bus 
> 'virtual-css-bus'
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/acceptance/virtio_check_params.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/acceptance/virtio_check_params.py 
> b/tests/acceptance/virtio_check_params.py
> index 2c14af825d..3466aa5b32 100755
> --- a/tests/acceptance/virtio_check_params.py
> +++ b/tests/acceptance/virtio_check_params.py
> @@ -81,6 +81,7 @@ class VirtioMaxSegSettingsCheck(Test):
>          logger.debug(mt)
>          with QEMUMachine(self.qemu_bin) as vm:
>              vm.set_machine(mt["name"])
> +            vm.add_args('-nodefaults')
>              for s in VM_DEV_PARAMS[dev_type_name]:
>                  vm.add_args(s)
>              try:
> 

Reviewed-by: Thomas Huth <address@hidden>