[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/46] tests/boot_linux_console: use os.path for filesystem paths
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 14/46] tests/boot_linux_console: use os.path for filesystem paths |
Date: |
Thu, 6 Feb 2020 22:19:04 +0100 |
From: Liam Merwick <address@hidden>
Change extract_from_deb() to use os.path routines to manipulate the
filesystem path returned when extracting a file.
Suggested-by: Wainer dos Santos Moschetta <address@hidden>
Signed-off-by: Liam Merwick <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/acceptance/boot_linux_console.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index 16b7503b5f..dca0a940ab 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -49,7 +49,12 @@ class BootLinuxConsole(Test):
process.run("ar x %s %s" % (deb, file_path))
archive.extract(file_path, self.workdir)
os.chdir(cwd)
- return self.workdir + path
+ # Return complete path to extracted file. Because callers to
+ # extract_from_deb() specify 'path' with a leading slash, it is
+ # necessary to use os.path.relpath() as otherwise os.path.join()
+ # interprets it as an absolute path and drops the self.workdir part.
+ return os.path.normpath(os.path.join(self.workdir,
+ os.path.relpath(path, '/')))
def extract_from_rpm(self, rpm, path):
"""
--
2.21.1
- [PULL 05/46] python/qemu: qmp: Remove unnused attributes, (continued)
- [PULL 05/46] python/qemu: qmp: Remove unnused attributes, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 03/46] python/qemu: qmp: Make accept()'s timeout configurable, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 06/46] python/qemu: accel: Fix kvm_available() on ppc64le, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 07/46] qemu-deprecated: Remove text about Python 2, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 08/46] python: Treat None-return of greeting cmd, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 09/46] python/qemu/machine: Allow to use other serial consoles than default, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 10/46] Acceptance tests: Extract _console_interaction(), Philippe Mathieu-Daudé, 2020/02/06
- [PULL 11/46] Acceptance tests: Add interrupt_interactive_console_until_pattern(), Philippe Mathieu-Daudé, 2020/02/06
- [PULL 12/46] travis.yml: install rpm2cpio for acceptance tests, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 13/46] tests/boot_linux_console: add extract_from_rpm method, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 14/46] tests/boot_linux_console: use os.path for filesystem paths,
Philippe Mathieu-Daudé <=
- [PULL 15/46] tests/boot_linux_console: fix extract_from_deb() comment, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 16/46] tests/boot_linux_console: Tag Emcraft Smartfusion2 as running 'u-boot', Philippe Mathieu-Daudé, 2020/02/06
- [PULL 18/46] tests: rename virtio_seg_max_adjust to virtio_check_params, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 17/46] tests/acceptance: Add boot tests for some of the QEMU advent calendar images, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 20/46] tests/acceptance/virtio_check_params: List machine being tested, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 24/46] tests/acceptance/version: Default to -nodefaults, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 23/46] tests/acceptance/boot_linux_console: Do not use VGA on Clipper machine, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 21/46] tests/acceptance/virtio_check_params: Default to -nodefaults, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 19/46] tests/acceptance/virtio_check_params: Improve exception logging, Philippe Mathieu-Daudé, 2020/02/06
- [PULL 22/46] tests/acceptance/virtio_check_params: Disable the test, Philippe Mathieu-Daudé, 2020/02/06