qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 31/46] scripts/checkpatch.pl: Only allow Python 3 interpreter


From: Philippe Mathieu-Daudé
Subject: [PULL 31/46] scripts/checkpatch.pl: Only allow Python 3 interpreter
Date: Thu, 6 Feb 2020 22:19:21 +0100

Since commit ddf9069963 QEMU requires Python >= 3.5.

PEP 0394 [*] states that 'python3' should be available and
that 'python' is optional.

To avoid problem with unsupported versions, enforce the
shebang interpreter to Python 3.

[*] https://www.python.org/dev/peps/pep-0394/

Reported-by: John Snow <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3aef6e3dfe..ce43a306f8 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1460,6 +1460,12 @@ sub process {
                        }
                }
 
+# Only allow Python 3 interpreter
+               if ($realline == 1 &&
+                       $line =~ /^\+#!\ *\/usr\/bin\/(?:env )?python$/) {
+                       ERROR("please use python3 interpreter\n" . $herecurr);
+               }
+
 # Accept git diff extended headers as valid patches
                if ($line =~ /^(?:rename|copy) (?:from|to) [\w\/\.\-]+\s*$/) {
                        $is_patch = 1;
-- 
2.21.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]