[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/29] qapi: Fix indent level on doc comments in json files
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 09/29] qapi: Fix indent level on doc comments in json files |
Date: |
Fri, 07 Feb 2020 10:31:56 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> The texinfo doc generation doesn't care much about
> indentation levels, but we would like to add a rST
> backend, and rST does care about indentation.
>
> Make the doc comments more strongly consistent about indentation
> for multiline constructs like:
>
> @arg: description line 1
> description line 2
>
> Returns: line one
> line 2
>
> so that there is always exactly one space after the
> colon, and subsequent lines align with the first.
>
> This commit is a purely whitespace change, and it does
> not alter the generated .texi files (because the texi
> generation code strips away all the extra whitespace).
> This does mean that we end up with some over-length lines.
Overlong lines need to be corrected. Not necessarily in this patch.
> Note that when the documentation for an argument fits
> on a single line like this:
>
> @arg: one line only
>
> then stray extra spaces after the ':' don't affect the
> rST output, so I have not attempted to methodically
> fix them, though the preference is a single space here too.
>
> Signed-off-by: Peter Maydell <address@hidden>
Same commit message body as PATCH 05, except for the line wrapping.
I like PATCH 05's better.
- [PATCH 14/29] qapi/block-core.json: Use explicit bulleted lists, (continued)
[PATCH 09/29] qapi: Fix indent level on doc comments in json files, Peter Maydell, 2020/02/06
- Re: [PATCH 09/29] qapi: Fix indent level on doc comments in json files,
Markus Armbruster <=
[PATCH 27/29] qga/qapi-schema.json: Add some headings, Peter Maydell, 2020/02/06
[PATCH 22/29] scripts/qapi/parser.py: improve doc comment indent handling, Peter Maydell, 2020/02/06
[PATCH 26/29] qapi: Use rST markup for literal blocks, Peter Maydell, 2020/02/06
[PATCH 24/29] docs/interop: Convert qemu-ga-ref to rST, Peter Maydell, 2020/02/06
[PATCH 23/29] docs/sphinx: Add new qapi-doc Sphinx extension, Peter Maydell, 2020/02/06
[PATCH 25/29] docs/interop: Convert qemu-qmp-ref to rST, Peter Maydell, 2020/02/06
[PATCH 28/29] scripts/qapi: Remove texinfo generation support, Peter Maydell, 2020/02/06
[PATCH 29/29] docs/devel/qapi-code-gen.txt: Update to new rST backend conventions, Peter Maydell, 2020/02/06
Re: [PATCH 00/29] Convert QAPI doc comments to generate rST instead of texinfo, Peter Maydell, 2020/02/06