[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs
From: |
Alex Bennée |
Subject: |
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs |
Date: |
Fri, 07 Feb 2020 11:08:15 +0000 |
User-agent: |
mu4e 1.3.7; emacs 27.0.60 |
Thomas Huth <address@hidden> writes:
> On 03/02/2020 04.23, Cleber Rosa wrote:
>> This is a crude and straightforward mapping of Peter's
>> "remake-merge-builds" and "pull-buildtest" scripts.
<snip>
>
> Thanks for doing this! The patch looks basically fine to me, but some
> comments below...
>
<snip>
>
> Question to Peter/Alex/Stefan/Howevermergespullreqsinthefuture:
>
> Should the above jobs really be skipped for pull requests, or would it
> be ok to include them there, too? (in the latter case, the above changes
> could just be dropped)
I think there is certainly value in having different stages of testing.
At least initially we'll want to match as closely to the current system
and then I imagine as we go on there will be trade-offs to be made in
how much is gating PRs and how much is retroactive and catches things
that slip through. While more testing is good we can't exponentially
grow what is reasonable to test for on all PRs.
<snip>
--
Alex Bennée
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs, Thomas Huth, 2020/02/07
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs, Peter Maydell, 2020/02/07
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs, Cleber Rosa, 2020/02/07
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs, Peter Maydell, 2020/02/08
Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs, Cleber Rosa, 2020/02/07
Re: [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs, Wainer dos Santos Moschetta, 2020/02/03
Re: [RFC PATCH 1/2] GitLab CI: avoid calling before_scripts on unintended jobs, Thomas Huth, 2020/02/03