Re: [PATCH v2 28/29] tests/acceptance/version: Default to -nodefaults

[Wainer dos Santos Moschetta]

On 1/29/20 7:23 PM, Philippe Mathieu-Daudé wrote:
> We don't need the default options to run this test.
>
> This fixes errors when running a binary built with
> --without-default-devices such:
>
>    ERROR: qemu-system-arm: Unsupported NIC model: virtio-net-pci
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>   tests/acceptance/version.py | 1 +
>   1 file changed, 1 insertion(+)

My comments in [1] also applies for this change. So:

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>

[1] https://www.mail-archive.com/address@hidden/msg675104.html


> diff --git a/tests/acceptance/version.py b/tests/acceptance/version.py
> index 67c2192c93..79b923d4fc 100644
> --- a/tests/acceptance/version.py
> +++ b/tests/acceptance/version.py
> @@ -17,6 +17,7 @@ class Version(Test):
>       :avocado: tags=quick
>       """
>       def test_qmp_human_info_version(self):
> +        self.vm.add_args('-nodefaults')
>           self.vm.launch()
>           res = self.vm.command('human-monitor-command',
>                                 command_line='info version')