Re: [PULL 12/12] audio: proper support for float samples in mixeng

[Eric Blake]

On 2/7/20 1:45 AM, Gerd Hoffmann wrote:
> From: Kővágó, Zoltán <address@hidden>
>
> This adds proper support for float samples in mixeng by adding a new
> audio format for it.
>
> Limitations: only native endianness is supported.  None of the virtual
> sound cards support float samples (it looks like most of them only
> support 8 and 16 bit, only hda supports 32 bit), it is only used for the
> audio backends (i.e. host side).
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> Acked-by: Markus Armbruster <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---

> +++ b/qapi/audio.json
> @@ -276,7 +276,7 @@
>   # Since: 4.0
>   ##
>   { 'enum': 'AudioFormat',
> -  'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32' ] }
> +  'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32', 'f32' ] }

Review suggested that this should add documentation including a since 
tag; that would now need to be a separate patch (unless this pull 
request is resun for other reasons)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org