[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/7] ui: add show-cursor option
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 1/7] ui: add show-cursor option |
Date: |
Fri, 07 Feb 2020 14:56:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> When enabled, this forces showing the mouse cursor,
> i.e. do not hide the pointer on mouse grabs.
> Defaults to off.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi/ui.json | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index e04525d8b44b..b9df7fe7b5cb 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1144,6 +1144,8 @@
> # @type: Which DisplayType qemu should use.
> # @full-screen: Start user interface in fullscreen mode (default: off).
> # @window-close: Allow to quit qemu with window close button (default: on).
> +# @show-cursor: Force showing the mouse cursor (default: off).
> +# Since: 5.0
By convention, we use
# Since: 5.0
for top-level definitions, and
# (since 5.0)
for members and such. See docs/devel/qapi-code-gen.txt section
"Definition documentation".
> # @gl: Enable OpenGL support (default: off).
> #
> # Since: 2.12
> @@ -1153,6 +1155,7 @@
> 'base' : { 'type' : 'DisplayType',
> '*full-screen' : 'bool',
> '*window-close' : 'bool',
> + '*show-cursor' : 'bool',
> '*gl' : 'DisplayGLMode' },
> 'discriminator' : 'type',
> 'data' : { 'gtk' : 'DisplayGTK',
With the doc comment tidied up:
Reviewed-by: Markus Armbruster <address@hidden>
- [PATCH v3 0/7] ui: rework -show-cursor option, Gerd Hoffmann, 2020/02/07
- [PATCH v3 2/7] ui: wire up legacy -show-cursor option, Gerd Hoffmann, 2020/02/07
- [PATCH v3 3/7] ui/sdl: switch to new show-cursor option, Gerd Hoffmann, 2020/02/07
- [PATCH v3 7/7] ui: deprecate legacy -show-cursor option, Gerd Hoffmann, 2020/02/07
- [PATCH v3 6/7] ui: drop curor_hide global variable., Gerd Hoffmann, 2020/02/07
- [PATCH v3 5/7] ui/gtk: implement show-cursor option, Gerd Hoffmann, 2020/02/07
- [PATCH v3 1/7] ui: add show-cursor option, Gerd Hoffmann, 2020/02/07
- Re: [PATCH v3 1/7] ui: add show-cursor option,
Markus Armbruster <=
- [PATCH v3 4/7] ui/cocoa: switch to new show-cursor option, Gerd Hoffmann, 2020/02/07
- Re: [PATCH v3 0/7] ui: rework -show-cursor option, Ján Tomko, 2020/02/08