[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments |
Date: |
Sat, 08 Feb 2020 08:54:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On Fri, 7 Feb 2020 at 14:43, Markus Armbruster <address@hidden> wrote:
>
>
>> Here's a style I'd dislike less:
[...]
>> # @file:
>> # Node to create the image format on
>> #
>> # @size:
>> # Size of the virtual disk in bytes
>> #
>> # @log-size:
>> # Log size in bytes, must be a multiple of 1 MB (default: 1 MB)
>> #
>> # @block-size:
>> # Block size in bytes, must be a multiple of 1 MB and not larger
>> # than 256 MB (default: automatically choose a block size depending
>> # on the image size)
>> #
>> # @subformat:
>> # vhdx subformat (default: dynamic)
>> #
>> # @block-state-zero:
>> # Force use of payload blocks of type 'ZERO'. Non-standard, but
>> # default. Do not set to 'off' when using 'qemu-img convert' with
>> # subformat=dynamic.
>
> Conveniently this patchset already supports this format :-)
> You can write either
>
> # @foo: bar
> # baz
> # indented
>
> or
> # @foo:
> # bar
> # baz
> # indented
>
> and they'll come out to the same thing (the parser.py code
> sends the same doc strings to the rST visitor).
If we enforce the second format in the QAPI schema parser, we save
ourselves the trouble of normalizing the first format to the second one.
We also promote more uniform style.
- Re: [PATCH 07/29] qapi/block-core.json: Use literal block for ascii art, (continued)
- [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Peter Maydell, 2020/02/06
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Markus Armbruster, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Max Reitz, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Kevin Wolf, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Peter Maydell, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Markus Armbruster, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Max Reitz, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Kevin Wolf, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Peter Maydell, 2020/02/07
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments,
Markus Armbruster <=
- Re: [PATCH 08/29] qapi: Use ':' after @argument in doc comments, Peter Maydell, 2020/02/08
[PATCH 11/29] qapi/ui.json: Put input-send-event body text in the right place, Peter Maydell, 2020/02/06
[PATCH 13/29] qapi/ui.json: Avoid `...' texinfo style quoting, Peter Maydell, 2020/02/06
[PATCH 12/29] qapi: Explicitly put "foo: dropped in n.n" notes into Notes section, Peter Maydell, 2020/02/06
[PATCH 10/29] qapi: Remove hardcoded tabs, Peter Maydell, 2020/02/06