Re: [PATCH v15 3/9] virtio-iommu: Implement attach/detach command

[Auger Eric]

Hi Peter,

On 2/8/20 2:41 PM, Peter Xu wrote:
> On Sat, Feb 08, 2020 at 01:00:16PM +0100, Eric Auger wrote:
>> This patch implements the endpoint attach/detach to/from
>> a domain.
>>
>> Domain and endpoint internal datatypes are introduced.
>> Both are stored in RB trees. The domain owns a list of
>> endpoints attached to it. Also helpers to get/put
>> end points and domains are introduced.
>>
>> As for the IOMMU memory regions, a callback is called on
>> PCI bus enumeration that initializes for a given device
>> on the bus hierarchy an IOMMU memory region. The PCI bus
>> hierarchy is stored locally in IOMMUPciBus and IOMMUDevice
>> objects.
>>
>> At the time of the enumeration, the bus number may not be
>> computed yet.
>>
>> So operations that will need to retrieve the IOMMUdevice
>> and its IOMMU memory region from the bus number and devfn,
>> once the bus number is garanteed to be frozen, use an array
>> of IOMMUPciBus, lazily populated.
>>
>> Signed-off-by: Eric Auger <address@hidden>
> 
> Reviewed-by: Peter Xu <address@hidden>
> 
> (Hope this is the last one missing r-b besides patch 8, I'll leave
>  patch 8 for the others or Michael when merging)

Sure. Many thanks!

Best Regards

Eric
> 
> Thanks,
>