Re: [PATCH v5 3/4] spapr: Add NVDIMM device support

[Shivaprasad G Bhat]

On 02/04/2020 09:29 AM, David Gibson wrote:
> On Thu, Jan 30, 2020 at 05:48:15AM -0600, Shivaprasad G Bhat wrote:
> > Add support for NVDIMM devices for sPAPR. Piggyback on existing nvdimm
> > device interface in QEMU to support virtual NVDIMM devices for Power.
> > Create the required DT entries for the device (some entries have
> > dummy values right now).
> >
> > The patch creates the required DT node and sends a hotplug
> > interrupt to the guest. Guest is expected to undertake the normal
> > DR resource add path in response and start issuing PAPR SCM hcalls.
> >
> > +                       " must be a multiple of %" PRIu64 "MB",
> > +                       SPAPR_MINIMUM_SCM_BLOCK_SIZE / MiB);
> > +            return;
> > +        }
> > +
> > +        uuidstr = object_property_get_str(OBJECT(dimm), NVDIMM_UUID_PROP, 
> > NULL);
> > +        qemu_uuid_parse(uuidstr, &uuid);
> Uh.. couldn't we just look at nvdimm->uuid, rather than getting the
> string property and parsing it again?

Addressing all except this one as discussed. Posting the next version in 
a while.

Thanks,
Shivaprasad