[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 2/4] q800: add a block backend to the PRAM
From: |
Laurent Vivier |
Subject: |
Re: [PULL 2/4] q800: add a block backend to the PRAM |
Date: |
Mon, 10 Feb 2020 13:00:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 10/02/2020 à 12:51, Peter Maydell a écrit :
> On Fri, 24 Jan 2020 at 12:48, Peter Maydell <address@hidden> wrote:
>>
>> On Tue, 7 Jan 2020 at 14:40, Laurent Vivier <address@hidden> wrote:
>>>
>>> This allows to save and restore the content of the PRAM.
>>> It may be useful if we want to check the configuration or to change it.
>>>
>>> The backend is added using mtd interface, for instance:
>>>
>>> ... -drive file=pram.img,format=raw,if=mtd ...
>>>
>>> where pram.img is the file where the data will be stored, its size must
>>> be 256 bytes.
>>>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> Message-Id: <address@hidden>
>>> +static void pram_update(MacVIAState *m)
>>> +{
>>> + if (m->blk) {
>>> + blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,
>>> + sizeof(m->mos6522_via1.PRAM), 0);
>>> + }
>>> +}
>>
>> Hi -- Coverity warns (CID 1412799) that this isn't checking
>> the return value from blk_pwrite().
>
> Ping -- what should we do about this Coverity issue ?
Sorry, I didn't see your first mail.
I have a look.
Thanks,
Laurent