Re: [RFC PATCH 55/66] Hexagon HVX import instruction encodings

[Philippe Mathieu-Daudé]

Hi Taylor,

On 2/11/20 1:40 AM, Taylor Simpson wrote:
> Signed-off-by: Taylor Simpson <address@hidden>
> ---
>   target/hexagon/imported/allextenc.def        |  20 +
>   target/hexagon/imported/encode.def           |   1 +
>   target/hexagon/imported/mmvec/encode_ext.def | 830 +++++++++++++++++++++++++++
>   3 files changed, 851 insertions(+)
>   create mode 100644 target/hexagon/imported/allextenc.def
>   create mode 100644 target/hexagon/imported/mmvec/encode_ext.def
>
> diff --git a/target/hexagon/imported/allextenc.def 
> b/target/hexagon/imported/allextenc.def
> new file mode 100644
> index 0000000..c194cc8
> --- /dev/null
> +++ b/target/hexagon/imported/allextenc.def
> @@ -0,0 +1,20 @@
> +/*
> + *  Copyright (c) 2019 Qualcomm Innovation Center, Inc. All Rights Reserved.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#define EXTNAME mmvec
> +#include "mmvec/encode_ext.def"
> +#undef EXTNAME
> diff --git a/target/hexagon/imported/encode.def 
> b/target/hexagon/imported/encode.def
> index 33c3396..d1b3510 100644
> --- a/target/hexagon/imported/encode.def
> +++ b/target/hexagon/imported/encode.def
> @@ -71,6 +71,7 @@
>   
>   #include "encode_pp.def"
>   #include "encode_subinsn.def"
> +#include "allextenc.def"
>   
>   #ifdef __SELF_DEF_FIELD32
>   #undef __SELF_DEF_FIELD32

I had a problem applying this one:

Applying: Hexagon HVX import instruction encodings
error: target/hexagon/imported/encode.def: does not exist in index
Patch failed at 0054 Hexagon HVX import instruction encodings
hint: Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Resolved by doing:

(review/hexagon|AM 54/65)$ touch target/hexagon/imported/encode.def
(review/hexagon|AM 54/65)$ git add target/hexagon/imported/encode.def
(review/hexagon|AM 54/65)$ git am --continue
Applying: Hexagon HVX import instruction encodings
Applying: Hexagon HVX import semantics
...