[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/8] multifd: Make no compression operations into its own
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v5 3/8] multifd: Make no compression operations into its own structure |
|
Date: |
Tue, 11 Feb 2020 12:23:51 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> It will be used later.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>
>> diff --git a/migration/multifd.h b/migration/multifd.h
>> index d8b0205977..c7fea4914c 100644
>> --- a/migration/multifd.h
>> +++ b/migration/multifd.h
>> @@ -25,6 +25,10 @@ int multifd_queue_page(QEMUFile *f, RAMBlock *block,
>> ram_addr_t offset);
>>
>> #define MULTIFD_FLAG_SYNC (1 << 0)
>>
>> +/* We reserve 3 bits for METHODS */
>> +#define MULTIFD_FLAG_METHOD_MASK (7 << 1)
>> +#define MULTIFD_FLAG_NOCOMP (1 << 1)
>> +
>
> Doesn't the 'NOCOMP' value have to be 0 for it to not break
> compatibility with existing multifd?
You are right. fixing on next resend.
Thanks.