qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 15/33] block: Pull out bdrv_default_perms_for_backing()


From: Eric Blake
Subject: Re: [PATCH v2 15/33] block: Pull out bdrv_default_perms_for_backing()
Date: Tue, 11 Feb 2020 09:38:32 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/6/20 5:19 AM, Max Reitz wrote:
On 05.02.20 21:56, Eric Blake wrote:
On 2/4/20 11:08 AM, Max Reitz wrote:
Signed-off-by: Max Reitz <address@hidden>

Rather light on the commit message. But looks like straightforward
refactoring (with the previous patch making it easier to follow).

Would this work:

Right now, bdrv_format_default_perms() is used by format parents
(generally). We want to switch to a model where most parents use a
single BdrvChildClass, which then decides the permissions based on the
child role. To do so, we have to split bdrv_format_default_perms() into
separate functions for each such role.

?

Yes.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]