[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/5] tests/plugin: prevent uninitialized warning
From: |
Richard Henderson |
Subject: |
Re: [PATCH v1 3/5] tests/plugin: prevent uninitialized warning |
Date: |
Tue, 11 Feb 2020 09:57:30 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/7/20 7:01 AM, Alex Bennée wrote:
> From: Chen Qun <address@hidden>
>
> According to the glibc function requirements, we need initialise
s/glibc/glib/
> the variable. Otherwise there will be compilation warnings:
>
> glib-autocleanups.h:28:3: warning: ‘out’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> g_free (*pp);
> ^~~~~~~~~~~~
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Message-Id: <address@hidden>
> [AJB: uses Thomas's single line allocation]
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> tests/plugin/bb.c | 6 +++---
> tests/plugin/insn.c | 3 +--
> 2 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v1 0/5] plugins/next, Alex Bennée, 2020/02/07
- [PATCH v1 2/5] plugins/core: add missing break in cb_to_tcg_flags, Alex Bennée, 2020/02/07
- [PATCH v1 3/5] tests/plugin: prevent uninitialized warning, Alex Bennée, 2020/02/07
- Re: [PATCH v1 3/5] tests/plugin: prevent uninitialized warning,
Richard Henderson <=
- [PATCH v1 4/5] target/riscv: progressively load the instruction during decode, Alex Bennée, 2020/02/07
- [PATCH v1 5/5] tests/plugins: make howvec clean-up after itself., Alex Bennée, 2020/02/07
- [PATCH v1 1/5] docs/devel: document query handle lifetimes, Alex Bennée, 2020/02/07