[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 04/23] module: check module wasn't already initialized
From: |
Alexander Bulekov |
Subject: |
[PATCH v9 04/23] module: check module wasn't already initialized |
Date: |
Tue, 11 Feb 2020 15:34:51 -0500 |
The virtual-device fuzzer must initialize QOM, prior to running
vl:qemu_init, so that it can use the qos_graph to identify the arguments
required to initialize a guest for libqos-assisted fuzzing. This change
prevents errors when vl:qemu_init tries to (re)initialize the previously
initialized QOM module.
Signed-off-by: Alexander Bulekov <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
util/module.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/util/module.c b/util/module.c
index 8c5315a7a3..236a7bb52a 100644
--- a/util/module.c
+++ b/util/module.c
@@ -30,6 +30,7 @@ typedef struct ModuleEntry
typedef QTAILQ_HEAD(, ModuleEntry) ModuleTypeList;
static ModuleTypeList init_type_list[MODULE_INIT_MAX];
+static bool modules_init_done[MODULE_INIT_MAX];
static ModuleTypeList dso_init_list;
@@ -91,11 +92,17 @@ void module_call_init(module_init_type type)
ModuleTypeList *l;
ModuleEntry *e;
+ if (modules_init_done[type]) {
+ return;
+ }
+
l = find_type(type);
QTAILQ_FOREACH(e, l, node) {
e->init();
}
+
+ modules_init_done[type] = true;
}
#ifdef CONFIG_MODULES
--
2.25.0
- [PATCH v9 00/23] Add virtual device fuzzing support, Alexander Bulekov, 2020/02/11
- [PATCH v9 01/23] checkpatch: replace vl.c in the top of repo check, Alexander Bulekov, 2020/02/11
- [PATCH v9 02/23] softmmu: move vl.c to softmmu/, Alexander Bulekov, 2020/02/11
- [PATCH v9 04/23] module: check module wasn't already initialized,
Alexander Bulekov <=
- [PATCH v9 03/23] softmmu: split off vl.c:main() into main.c, Alexander Bulekov, 2020/02/11
- [PATCH v9 05/23] fuzz: add FUZZ_TARGET module type, Alexander Bulekov, 2020/02/11
- [PATCH v9 06/23] qtest: add qtest_server_send abstraction, Alexander Bulekov, 2020/02/11
- [PATCH v9 11/23] libqos: split qos-test and libqos makefile vars, Alexander Bulekov, 2020/02/11
- [PATCH v9 09/23] qtest: add in-process incoming command handler, Alexander Bulekov, 2020/02/11
- [PATCH v9 10/23] libqos: rename i2c_send and i2c_recv, Alexander Bulekov, 2020/02/11
- [PATCH v9 07/23] libqtest: add a layer of abstraction to send/recv, Alexander Bulekov, 2020/02/11
- [PATCH v9 08/23] libqtest: make bufwrite rely on the TransportOps, Alexander Bulekov, 2020/02/11
- [PATCH v9 15/23] main: keep rcu_atfork callback enabled for qtest, Alexander Bulekov, 2020/02/11
- [PATCH v9 12/23] libqos: move useful qos-test funcs to qos_external, Alexander Bulekov, 2020/02/11