[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 2/2] virtio-gpu: add the ability to export resources
From: |
Gerd Hoffmann |
Subject: |
Re: [RFC PATCH v3 2/2] virtio-gpu: add the ability to export resources |
Date: |
Wed, 12 Feb 2020 12:50:51 +0100 |
On Fri, Feb 07, 2020 at 04:40:33PM +0900, David Stevens wrote:
> Signed-off-by: David Stevens <address@hidden>
> ---
> virtio-gpu.tex | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/virtio-gpu.tex b/virtio-gpu.tex
> index af4ca61..e950ad3 100644
> --- a/virtio-gpu.tex
> +++ b/virtio-gpu.tex
> @@ -186,12 +186,16 @@ \subsubsection{Device Operation: Request
> header}\label{sec:Device Types / GPU De
> VIRTIO_GPU_CMD_UPDATE_CURSOR = 0x0300,
> VIRTIO_GPU_CMD_MOVE_CURSOR,
>
> + /* misc commands */
> + VIRTIO_GPU_CMD_RESOURCE_ASSIGN_UUID = 0x0400,
I'd suggest to move that to the "2d commands" section (which isn't
really "2d" but more "not 3d").
We also need a feature flag signaling support for the new command.
Otherwise this looks ok to me.
Are there any patches and/or attempts to merge/discuss upstream?
Specifically for handling the uuids for dma-bufs in linux (guest side)?
I suspect there will be some discussions on this and having at least
some plan upstream can agree on would be good.
cheers,
Gerd