Re: [PATCH v2 01/16] virtio-mem: Prototype

[Eric Blake]

On 2/12/20 7:35 AM, David Hildenbrand wrote:
> Signed-off-by: David Hildenbrand <address@hidden>
> ---

It's at least worth mentioning VirtioMEMDeviceInfo in the commit 
message, to make it easier to find which commit introduces a given QAPI 
struct when searching the git log.

> +++ b/qapi/misc.json
> @@ -1557,19 +1557,56 @@
>             }
>   }
>   
> +##
> +# @VirtioMEMDeviceInfo:
> +#
> +# VirtioMEMDevice state information
> +#
> +# @id: device's ID
> +#
> +# @memaddr: physical address in memory, where device is mapped
> +#
> +# @requested-size: the user requested size of the device
> +#
> +# @size: the (current) size of memory that the device provides
> +#
> +# @max-size: the maximum size of memory that the device can provide
> +#
> +# @block-size: the block size of memory that the device provides
> +#
> +# @node: NUMA node number where device is assigned to
> +#
> +# @memdev: memory backend linked with the region
> +#
> +# Since: 4.1

5.0

> +##
> +{ 'struct': 'VirtioMEMDeviceInfo',
> +  'data': { '*id': 'str',

Does it make sense for id to be optional, or should it be mandatory?

> +            'memaddr': 'size',
> +            'requested-size': 'size',
> +            'size': 'size',
> +            'max-size': 'size',
> +            'block-size': 'size',
> +            'node': 'int',
> +            'memdev': 'str'
> +          }
> +}
> +
>   ##
>   # @MemoryDeviceInfo:
>   #
>   # Union containing information about a memory device
>   #
>   # nvdimm is included since 2.12. virtio-pmem is included since 4.1.
> +# virtio-mem is included since 4.2.

5.0

>   #
>   # Since: 2.1
>   ##
>   { 'union': 'MemoryDeviceInfo',
>     'data': { 'dimm': 'PCDIMMDeviceInfo',
>               'nvdimm': 'PCDIMMDeviceInfo',
> -            'virtio-pmem': 'VirtioPMEMDeviceInfo'
> +            'virtio-pmem': 'VirtioPMEMDeviceInfo',
> +            'virtio-mem': 'VirtioMEMDeviceInfo'
>             }
>   }
>   

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org