Re: [PATCH v30 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
babc84a qemu-doc.texi: Add RX section.
02671a3 BootLinuxConsoleTest: Test the RX-Virt machine
a7b171f Add rx-softmmu
157d061 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
6dd9e29 hw/rx: Honor -accel qtest
531f2e7 hw/rx: RX Target hardware definition
2f84384 hw/char: RX62N serial communication interface (SCI)
efb672d hw/timer: RX62N internal timer modules
2ecc8e8 hw/intc: RX62N interrupt controller (ICUa)
c48b1e3 target/rx: Dump bytes for each insn during disassembly
cf6bd23 target/rx: Collect all bytes during disassembly
0630f57 target/rx: Emit all disassembly in one prt()
c68232e target/rx: Use prt_ldmi for XCHG_mr disassembly
0c715cf target/rx: Replace operand with prt_ldmi in disassembler
56823e8 target/rx: Disassemble rx_index_addr into a string
bec88c6 target/rx: RX disassembler
e087756 target/rx: CPU definition
76fbf4b target/rx: TCG helper
077b749 target/rx: TCG translation
077083d hw/registerfields.h: Add 8bit and 16bit register macros
0e0b064 qemu/bitops.h: Add extract8 and extract16
e057d0d MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit e057d0d1eaa7 (MAINTAINERS: Add RX)
2/22 Checking commit 0e0b0640e7e8 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 077083db9152 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 077b74916e86 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 76fbf4b71e73 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit e087756e80bc (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit bec88c65c6d9 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 56823e81616e (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit 0c715cfcaf50 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit c68232e9cbaa (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit 0630f571ce7f (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit cf6bd23f5f99 (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit c48b1e310d06 (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 2ecc8e8d62d7 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit efb672d6bcee (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 2f843848c4d1 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 531f2e7ba4e9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 6dd9e29294c7 (hw/rx: Honor -accel qtest)
19/22 Checking commit 157d061f696c (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit a7b171fcf22b (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 02671a3e7d1a (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit babc84a4f27c (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden