[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [RFC PATCH 29/66] Hexagon opcode data structures
|
From: |
Taylor Simpson |
|
Subject: |
RE: [RFC PATCH 29/66] Hexagon opcode data structures |
|
Date: |
Wed, 12 Feb 2020 17:36:41 +0000 |
> -----Original Message-----
> From: Philippe Mathieu-Daudé <address@hidden>
> Sent: Tuesday, February 11, 2020 1:41 AM
> To: Taylor Simpson <address@hidden>; address@hidden
> Cc: address@hidden; address@hidden; address@hidden;
> address@hidden
> Subject: Re: [RFC PATCH 29/66] Hexagon opcode data structures
>
> > +#ifndef OPCODES_H
>
> HEXAGON_OPCODES_H
>
> I wonder if it would ease review to split this patch in 2, keep the C
> here, but provide opcodes.h in an earlier patch.
Wouldn't using scripts/git.orderfile solve this just as well? It will put
opcodes.h ahead of opcodes.c in this patch.
>
> > +#define OPCODES_H
> > +
- [RFC PATCH 06/66] Hexagon CPU Scalar Core Helpers, (continued)
- [RFC PATCH 06/66] Hexagon CPU Scalar Core Helpers, Taylor Simpson, 2020/02/10
- [RFC PATCH 24/66] Hexagon generator phase 2 - op_attribs_generated.h, Taylor Simpson, 2020/02/10
- [RFC PATCH 25/66] Hexagon generator phase 2 - op_regs_generated.h, Taylor Simpson, 2020/02/10
- [RFC PATCH 11/66] Hexagon instruction attributes, Taylor Simpson, 2020/02/10
- [RFC PATCH 28/66] Hexagon generater phase 4 - Decode tree, Taylor Simpson, 2020/02/10
- [RFC PATCH 29/66] Hexagon opcode data structures, Taylor Simpson, 2020/02/10
- [RFC PATCH 17/66] Hexagon arch import - instruction encoding, Taylor Simpson, 2020/02/10
- [RFC PATCH 27/66] Hexagon generator phase 3 - C preprocessor for decode tree, Taylor Simpson, 2020/02/10
- [RFC PATCH 13/66] Hexagon instruction/packet decode, Taylor Simpson, 2020/02/10
- [RFC PATCH 33/66] Hexagon TCG generation helpers - step 1, Taylor Simpson, 2020/02/10
- [RFC PATCH 16/66] Hexagon arch import - macro definitions, Taylor Simpson, 2020/02/10
- [RFC PATCH 21/66] Hexagon generator phase 2 - qemu_def_generated.h, Taylor Simpson, 2020/02/10
- [RFC PATCH 35/66] Hexagon TCG generation helpers - step 3, Taylor Simpson, 2020/02/10