[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL
From: |
Richard Henderson |
Subject: |
Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL |
Date: |
Wed, 12 Feb 2020 13:41:32 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/12/20 2:45 AM, Alex Bennée wrote:
>
> Richard Henderson <address@hidden> writes:
>
>> On 1/30/20 1:38 PM, Stefan Hajnoczi wrote:
>>> From: Salvador Fandino <address@hidden>
>>>
>>> NULL is a valid log filename used to indicate we want to use stderr
>>> but qemu_set_log_filename (which is called by bsd-user/main.c) was not
>>> handling it correctly.
>>>
>>> That also made redundant a couple of NULL checks in calling code which
>>> have been removed.
>>>
>>> Signed-off-by: Salvador Fandino <address@hidden>
>>> Message-Id: <address@hidden>
>>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>>> ---
>>> trace/control.c | 4 +---
>>> util/log.c | 28 ++++++++++++++++------------
>>> vl.c | 5 +----
>>> 3 files changed, 18 insertions(+), 19 deletions(-)
>>
>> This patch has broken -D <filename> for *-linux-user.
>> After e144a605a, all logging goes to stderr.
>
> I posted:
>
> Subject: [PATCH] tracing: only allow -trace to override -D if set
> Date: Tue, 11 Feb 2020 11:10:54 +0000
> Message-Id: <address@hidden>
>
> as a fix which partially reverted this.
Thanks, that fixes it for me.
r~