[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/6] migration: Maybe VM is paused when migration is cancelled
From: |
Juan Quintela |
Subject: |
[PULL 1/6] migration: Maybe VM is paused when migration is cancelled |
Date: |
Thu, 13 Feb 2020 14:20:25 +0100 |
From: Zhimin Feng <address@hidden>
If the migration is cancelled when it is in the completion phase,
the migration state is set to MIGRATION_STATUS_CANCELLING.
The VM maybe wait for the 'pause_sem' semaphore in migration_maybe_pause
function, so that VM always is paused.
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Zhimin Feng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/migration.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 3a21a4686c..1ca6be2323 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2797,14 +2797,22 @@ static int migration_maybe_pause(MigrationState *s,
/* This block intentionally left blank */
}
- qemu_mutex_unlock_iothread();
- migrate_set_state(&s->state, *current_active_state,
- MIGRATION_STATUS_PRE_SWITCHOVER);
- qemu_sem_wait(&s->pause_sem);
- migrate_set_state(&s->state, MIGRATION_STATUS_PRE_SWITCHOVER,
- new_state);
- *current_active_state = new_state;
- qemu_mutex_lock_iothread();
+ /*
+ * If the migration is cancelled when it is in the completion phase,
+ * the migration state is set to MIGRATION_STATUS_CANCELLING.
+ * So we don't need to wait a semaphore, otherwise we would always
+ * wait for the 'pause_sem' semaphore.
+ */
+ if (s->state != MIGRATION_STATUS_CANCELLING) {
+ qemu_mutex_unlock_iothread();
+ migrate_set_state(&s->state, *current_active_state,
+ MIGRATION_STATUS_PRE_SWITCHOVER);
+ qemu_sem_wait(&s->pause_sem);
+ migrate_set_state(&s->state, MIGRATION_STATUS_PRE_SWITCHOVER,
+ new_state);
+ *current_active_state = new_state;
+ qemu_mutex_lock_iothread();
+ }
return s->state == new_state ? 0 : -EINVAL;
}
--
2.24.1
- [PULL 0/6] Pull migration patches, Juan Quintela, 2020/02/13
- [PULL 1/6] migration: Maybe VM is paused when migration is cancelled,
Juan Quintela <=
- [PULL 2/6] migration: Optimization about wait-unplug migration state, Juan Quintela, 2020/02/13
- [PULL 3/6] migration/rdma: rdma_accept_incoming_migration fix error handling, Juan Quintela, 2020/02/13
- [PULL 4/6] tests/migration: Add some slack to auto converge, Juan Quintela, 2020/02/13
- [PULL 5/6] migration-test: fix some memleaks in migration-test, Juan Quintela, 2020/02/13
- [PULL 6/6] git: Make submodule check only needed modules, Juan Quintela, 2020/02/13
- Re: [PULL 0/6] Pull migration patches, Peter Maydell, 2020/02/14