Re: [PATCH v5 1/8] multifd: Add multifd-method parameter

[Juan Quintela]

Daniel P. Berrangé <address@hidden> wrote:
> On Wed, Jan 29, 2020 at 12:56:48PM +0100, Juan Quintela wrote:
>> This will store the compression method to use.  We start with none.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> ---
>>  hw/core/qdev-properties.c    | 13 +++++++++++++
>>  include/hw/qdev-properties.h |  3 +++
>>  migration/migration.c        | 13 +++++++++++++
>>  monitor/hmp-cmds.c           | 13 +++++++++++++
>>  qapi/migration.json          | 30 +++++++++++++++++++++++++++---
>>  tests/qtest/migration-test.c | 14 ++++++++++----
>>  6 files changed, 79 insertions(+), 7 deletions(-)
>> 
>> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
>> index 7f93bfeb88..4442844d37 100644
>> --- a/hw/core/qdev-properties.c
>> +++ b/hw/core/qdev-properties.c
>> @@ -8,6 +8,7 @@
>
>> @@ -488,6 +488,19 @@
>>  ##
>>  { 'command': 'query-migrate-capabilities', 'returns':   
>> ['MigrationCapabilityStatus']}
>>  
>> +##
>> +# @MultiFDMethod:
>> +#
>> +# An enumeration of multifd compression.
>> +#
>> +# @none: no compression.
>> +#
>> +# Since: 5.0
>> +#
>> +##
>> +{ 'enum': 'MultiFDMethod',
>> +  'data': [ 'none' ] }
>
> I feel like "MultiFDMethod" is better called "MultiFDCompression"

Changed.

Thanks, Juan.