[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/8] multifd: Add zstd compression multifd support
From: |
Juan Quintela |
Subject: |
Re: [PATCH v5 8/8] multifd: Add zstd compression multifd support |
Date: |
Thu, 13 Feb 2020 21:39:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> hw/core/qdev-properties.c | 2 +-
>> migration/Makefile.objs | 1 +
>> migration/migration.c | 9 +
>> migration/migration.h | 1 +
>> migration/multifd-zstd.c | 337 +++++++++++++++++++++++++++++++++++
>> migration/multifd.h | 2 +-
>> migration/ram.c | 1 -
>> qapi/migration.json | 4 +-
>> tests/qtest/migration-test.c | 10 ++
>> 9 files changed, 363 insertions(+), 4 deletions(-)
>> create mode 100644 migration/multifd-zstd.c
>> + res = ZSTD_initCStream(z->zcs, migrate_multifd_zstd_level());
>> + if (ZSTD_isError(res)) {
>> + ZSTD_freeCStream(z->zcs);
>> + g_free(z);
>> + error_setg(errp, "multifd %d: initCStream failed", p->id);
>
> It might be useful to print 'res' here - you seem to decode it on the
> receive side.
Fixed all callers.
>> @@ -163,6 +164,5 @@ typedef struct {
>> } MultiFDMethods;
>>
>> void multifd_register_ops(int method, MultiFDMethods *ops);
>> -
>
> Oddment.
oops. Removed the chunk.
>
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Thanks.