[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/19] tracing: only allow -trace to override -D if set
From: |
Alex Bennée |
Subject: |
[PATCH v2 09/19] tracing: only allow -trace to override -D if set |
Date: |
Thu, 13 Feb 2020 22:50:59 +0000 |
Otherwise any -D settings the user may have made get ignored.
Signed-off-by: Alex Bennée <address@hidden>
---
trace/control.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/trace/control.c b/trace/control.c
index 6c775e68eba..2ffe0008184 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -226,10 +226,15 @@ void trace_init_file(const char *file)
#ifdef CONFIG_TRACE_SIMPLE
st_set_trace_file(file);
#elif defined CONFIG_TRACE_LOG
- /* If both the simple and the log backends are enabled, "--trace file"
- * only applies to the simple backend; use "-D" for the log backend.
+ /*
+ * If both the simple and the log backends are enabled, "--trace file"
+ * only applies to the simple backend; use "-D" for the log
+ * backend. However we should only override -D if we actually have
+ * something to override it with.
*/
- qemu_set_log_filename(file, &error_fatal);
+ if (file) {
+ qemu_set_log_filename(file, &error_fatal);
+ }
#else
if (file) {
fprintf(stderr, "error: --trace file=...: "
--
2.20.1
- [PATCH v2 06/19] travis.yml: Fix Travis YAML configuration warnings, (continued)
- [PATCH v2 06/19] travis.yml: Fix Travis YAML configuration warnings, Alex Bennée, 2020/02/13
- [PATCH v2 04/19] tests/rcutorture: mild documenting refactor of update thread, Alex Bennée, 2020/02/13
- [PATCH v2 07/19] travis.yml: single-thread build-tcg stages, Alex Bennée, 2020/02/13
- [PATCH v2 08/19] tests/iotests: be a little more forgiving on the size test, Alex Bennée, 2020/02/13
- [PATCH v2 13/19] qemu/bitops.h: Add extract8 and extract16, Alex Bennée, 2020/02/13
- [PATCH v2 10/19] docs/devel: document query handle lifetimes, Alex Bennée, 2020/02/13
- [PATCH v2 11/19] plugins/core: add missing break in cb_to_tcg_flags, Alex Bennée, 2020/02/13
- [PATCH v2 09/19] tracing: only allow -trace to override -D if set,
Alex Bennée <=
- [PATCH v2 12/19] tests/plugin: prevent uninitialized warning, Alex Bennée, 2020/02/13
- [PATCH v2 17/19] tcg: save vaddr temp for plugin usage, Alex Bennée, 2020/02/13
- [PATCH v2 15/19] tests/plugins: make howvec clean-up after itself., Alex Bennée, 2020/02/13
- [PATCH v2 14/19] target/riscv: progressively load the instruction during decode, Alex Bennée, 2020/02/13
- [PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3, Alex Bennée, 2020/02/13