qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/30] qga/qapi-schema.json: Fix indent level on doc comme


From: Peter Maydell
Subject: Re: [PATCH v2 05/30] qga/qapi-schema.json: Fix indent level on doc comments
Date: Fri, 14 Feb 2020 12:40:49 +0000

On Fri, 14 Feb 2020 at 12:36, Markus Armbruster <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>
> > The texinfo doc generation doesn't care much about indentation
>
> Let's spell Texinfo with a capital T.
>
> > levels, but we would like to add a rST backend, and rST does care
> > about indentation.
>
> Nitpick: an rST *backend* should not care about the doc generator's
> *input* format.  We actually intend to change the input format into a
> domain-specific dialect of rST, as you state in your cover letter: "This
> series switches all our QAPI doc comments over from texinfo format to
> rST."
>
> Perhaps:
>
>   The current doc generation doesn't care much about indentation levels,
>   but we would like to switch to an rST format, and rST does care about
>   indentation.

Works for me. Let me know if you're OK just making this kind
of commit message tweak/minor fixup and sending a pull, or
if you want me to roll a v3.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]