[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists |
|
Date: |
Fri, 14 Feb 2020 18:11:16 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On Fri, 14 Feb 2020 at 16:02, Markus Armbruster <address@hidden> wrote:
>>
>> Markus Armbruster <address@hidden> writes:
>>
>> > Peter Maydell <address@hidden> writes:
>> >
>> >> rST insists on a blank line before and after a bulleted list,
>> >> but our texinfo doc generator did not. Add some extra blank
>> >> lines in the doc comments so they're acceptable rST input.
>> >>
>> >> Signed-off-by: Peter Maydell <address@hidden>
>> >> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> >
>> > Reviewed-by: Markus Armbruster <address@hidden>
>>
>> Hmm, PATCH 06 appears to do the same, among other things. Sure you want
>> this separate?
>
> Patch 6 is qga/; this is qapi/.
D'oh!
> This is again a product of my general preference for more
> smaller patches rather than larger patches that touch more
> files at once.
Makes sense, thanks!
- Re: [PATCH v2 08/30] qapi: Use ':' after @argument in doc comments, (continued)
- [PATCH v2 11/30] qapi/ui.json: Put input-send-event body text in the right place, Peter Maydell, 2020/02/13
- [PATCH v2 12/30] qapi/ui.json: Avoid `...' texinfo style quoting, Peter Maydell, 2020/02/13
- [PATCH v2 13/30] qapi/block-core.json: Use explicit bulleted lists, Peter Maydell, 2020/02/13
- [PATCH v2 14/30] qapi/ui.json: Use explicit bulleted lists, Peter Maydell, 2020/02/13
- [PATCH v2 16/30] qapi: Add blank lines before bulleted lists, Peter Maydell, 2020/02/13
[PATCH v2 18/30] qapi: Delete all the "foo: dropped in n.n" notes, Peter Maydell, 2020/02/13
[PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists, Peter Maydell, 2020/02/13
- Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists, Markus Armbruster, 2020/02/14
- Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists, Peter Maydell, 2020/02/14
- Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists, Markus Armbruster, 2020/02/14
- Re: [PATCH v2 15/30] qapi/{block, misc, tmp, net}.json: Use explicit bulleted lists, Peter Maydell, 2020/02/14
[PATCH v2 19/30] qapi/qapi-schema.json: Put headers in their own doc-comment blocks, Peter Maydell, 2020/02/13