[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 18/21] target/arm: Test correct register in aa32_pan and a
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 18/21] target/arm: Test correct register in aa32_pan and aa32_ats1e1 checks |
|
Date: |
Fri, 14 Feb 2020 12:30:43 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/14/20 9:51 AM, Peter Maydell wrote:
> The isar_feature_aa32_pan and isar_feature_aa32_ats1e1 functions
> are supposed to be testing fields in ID_MMFR3; but a cut-and-paste
> error meant we were looking at MVFR0 instead.
>
> Fix the functions to look at the right register; this requires
> us to move at least id_mmfr3 to the ARMISARegisters struct; we
> choose to move all the ID_MMFRn registers for consistency.
>
> Fixes: 3d6ad6bb466f
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/cpu.h | 14 +++---
> hw/intc/armv7m_nvic.c | 8 ++--
> target/arm/cpu.c | 104 +++++++++++++++++++++---------------------
> target/arm/cpu64.c | 28 ++++++------
> target/arm/helper.c | 12 ++---
> target/arm/kvm32.c | 17 +++++++
> target/arm/kvm64.c | 10 ++++
> 7 files changed, 110 insertions(+), 83 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH v2 12/21] target/arm: Read debug-related ID registers from KVM, (continued)
- [PATCH v2 16/21] target/arm: Correct definition of PMCRDP, Peter Maydell, 2020/02/14
- [PATCH v2 14/21] target/arm: Implement ARMv8.4-PMU extension, Peter Maydell, 2020/02/14
- [PATCH v2 15/21] target/arm: Provide ARMv8.4-PMU in '-cpu max', Peter Maydell, 2020/02/14
- [PATCH v2 17/21] target/arm: Correct handling of PMCR_EL0.LC bit, Peter Maydell, 2020/02/14
- [PATCH v2 19/21] target/arm: Use isar_feature function for testing AA32HPD feature, Peter Maydell, 2020/02/14
- [PATCH v2 20/21] target/arm: Use FIELD_EX32 for testing 32-bit fields, Peter Maydell, 2020/02/14
- [PATCH v2 18/21] target/arm: Test correct register in aa32_pan and aa32_ats1e1 checks, Peter Maydell, 2020/02/14
- Re: [PATCH v2 18/21] target/arm: Test correct register in aa32_pan and aa32_ats1e1 checks,
Richard Henderson <=
- [PATCH v2 21/21] target/arm: Correctly implement ACTLR2, HACTLR2, Peter Maydell, 2020/02/14