[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/8] tests/acceptance/boot_linux_console: Use raspi console model
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 1/8] tests/acceptance/boot_linux_console: Use raspi console model as key |
Date: |
Sat, 15 Feb 2020 20:22:09 +0100 |
Python dictionary are not that expensive. Use a key makes the
code easier to review.
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/acceptance/boot_linux_console.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/acceptance/boot_linux_console.py
b/tests/acceptance/boot_linux_console.py
index 34d37eba3b..8cfc758d42 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -347,14 +347,14 @@ def test_arm_emcraft_sf2(self):
self.vm.launch()
self.wait_for_console_pattern('init started: BusyBox')
- def do_test_arm_raspi2(self, uart_id):
+ def do_test_arm_raspi2(self, uart_model):
"""
The kernel can be rebuilt using the kernel source referenced
and following the instructions on the on:
https://www.raspberrypi.org/documentation/linux/kernel/building.md
"""
serial_kernel_cmdline = {
- 0: 'earlycon=pl011,0x3f201000 console=ttyAMA0',
+ 'pl011': 'earlycon=pl011,0x3f201000 console=ttyAMA0',
}
deb_url = ('http://archive.raspberrypi.org/debian/'
'pool/main/r/raspberrypi-firmware/'
@@ -366,7 +366,7 @@ def do_test_arm_raspi2(self, uart_id):
self.vm.set_console()
kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
- serial_kernel_cmdline[uart_id])
+ serial_kernel_cmdline[uart_model])
self.vm.add_args('-kernel', kernel_path,
'-dtb', dtb_path,
'-append', kernel_command_line)
@@ -380,7 +380,7 @@ def test_arm_raspi2_uart0(self):
:avocado: tags=machine:raspi2
:avocado: tags=device:pl011
"""
- self.do_test_arm_raspi2(0)
+ self.do_test_arm_raspi2('pl011')
def test_arm_exynos4210_initrd(self):
"""
--
2.21.1
- [PATCH 0/8] hw/arm: Add raspi[0123] acceptance tests, Philippe Mathieu-Daudé, 2020/02/15
- [PATCH 1/8] tests/acceptance/boot_linux_console: Use raspi console model as key,
Philippe Mathieu-Daudé <=
- [PATCH 2/8] tests/acceptance/boot_linux_console: Add raspi version=2 parameter, Philippe Mathieu-Daudé, 2020/02/15
- [PATCH 3/8] tests/acceptance/boot_linux_console: Test the raspi1 console, Philippe Mathieu-Daudé, 2020/02/15
- [PATCH 4/8] tests/acceptance/boot_linux_console: Test the raspi0 console, Philippe Mathieu-Daudé, 2020/02/15
- [PATCH 5/8] tests/acceptance/boot_linux_console: Test the raspi1 AUX console, Philippe Mathieu-Daudé, 2020/02/15
- [PATCH 6/8] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 2, Philippe Mathieu-Daudé, 2020/02/15